Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make it easier to prepare more sizes (one for each of the action-bar sizes, for example) #21

Closed
AndroidDeveloperLB opened this issue Oct 31, 2014 · 19 comments

Comments

@AndroidDeveloperLB
Copy link

No description provided.

@Templarian
Copy link
Owner

Good idea. Will work on adding it next week when I'm back from vacation.

@AndroidDeveloperLB
Copy link
Author

Thank you.
Can you please add those icons:
sorting, wrench (manage), storage, data-usage, ecg, graph, trash-can (delete), settings
?
I might be wrong to think that some of them are missing, since it's a bit hard to find. Is there a way to search there?

Also, maybe you would like to merge your icons with those of Google:
https://github.com/google/material-design-icons
Not sure about the license though. I hope it's ok.

@Templarian
Copy link
Owner

All of those are getting adding at the moment, had to take break due to vacation. If you expand the contributor tab it actually shows the total from google that have been synced. x/757 right now I believe.

@AndroidDeveloperLB
Copy link
Author

oh, ok, thank you.
say, what does this license mean? is it ok for me to change the content?
Same goes for using your icons. What can't I do, and what should I do?

@AndroidDeveloperLB
Copy link
Author

I also think there should be a better naming for the files, something like here:
http://romannurik.github.io/AndroidAssetStudio/icons-actionbar.html

@Templarian
Copy link
Owner

Yes, that is a good idea for Android developers / iOS developers. I'm planning to cache a few download packages. Android, iOS, Web Developer, CSS / Fonts. And one that is more of a give me every export option available in one zip file.

Keep the ideas coming. This is my main open source project for the next few months while I build out the community. If you design icons also I can send you an invite to the contributor portal also.

@AndroidDeveloperLB
Copy link
Author

@Templarian I'm not a designer.
I use those icons for my app (link here: https://play.google.com/store/apps/details?id=com.lb.app_manager ) because I don't design stuff well. I've also mentioned your website on the licenses&thanks screen.

That's why I try to find some place that would make it easy to import the files I want.
For sizes, you could add the target (notification, actionbar, etc...), and the densities that the user wishes to create (combination of: mdpi,hdpi,xhdpi,...) .

You could also allow multi-selection, and also find-as-you-type. Seeing that you've already added keywords for the icons, this could be useful for the searching.

@Templarian
Copy link
Owner

Find as you type is already started (have not pushed it yet to production yet). I'll capture the CTRL+F or if the user simply just starts typing.

Multi-selection is also started (this is required for the sub font generation). Many have requested a way to build fonts based on a subset of the full icon set due to file size.

Yea, not everyone's a designer. No problem about that. I'll be enabling comments and other features for developer to give feedback and enhance tagging (all this will be public and doesn't require login).

I'll start focusing on these features you listed for the export. Generating the images / zip files are really easy from the SVG vectors it is just the batch process is very CPU intensive so I have to ensure it is carefully handled not to block up my servers page processing. The way I get around this is building out caching layer. The ZIP process is also a little memory intensive so I have to be careful (might see a more segmented "Please wait while we generate the required assets" prompt.

@AndroidDeveloperLB
Copy link
Author

I'm not an expert in HTML, but can't Javascript perform the hard work on the client side, instead of letting the server do the hard work?
This way, your server will only be responsible of SVG requests or something similar.

@Templarian
Copy link
Owner

Yea, I'll mess with the idea of using BlobBuilder. I could use the JSzip to build out all the smaller sub-selections.

I can go from SVG -> PNG canvas to blob -> ZIP.

@AndroidDeveloperLB
Copy link
Author

This is great news. Thank you.

@Templarian
Copy link
Owner

Closed another issue on adding 4.x legacy. It sort of relates to this issue. I'll leave this issue open till I've closed out the things we discussed.

image

@AndroidDeveloperLB
Copy link
Author

What is the purpose of "Android 5.x" ? is it in black? Shouldn't it also have a white version?
Also, how come it creates only 3 folders, and with names like "48" , "32" , ... ?

@Templarian
Copy link
Owner

Ha, coding that one right now. Should have commented it out before pushing it to production. Will be fixed up in the next hour or so. 😸

@AndroidDeveloperLB
Copy link
Author

ok, thank you.

@Templarian
Copy link
Owner

Oh yea. Forgot to reply to this. It has been resolved. The download for 5.x works correctly now.

The download generates 61 files in total. 😟 This makes me happy that Windows Phone uses vector assets. Ha.

@Templarian
Copy link
Owner

I'm going to close this issue now and create a new issue for

  • Search
  • Font Creation
  • iOS icons

@AndroidDeveloperLB
Copy link
Author

Thanks.

@AndroidDeveloperLB
Copy link
Author

It works great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants