Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astroid Menu Options negative margin #42

Closed
vtheod opened this issue Nov 24, 2021 · 22 comments · Fixed by #47
Closed

Astroid Menu Options negative margin #42

vtheod opened this issue Nov 24, 2021 · 22 comments · Fixed by #47

Comments

@vtheod
Copy link

vtheod commented Nov 24, 2021

Hey all!

This post is about a problem with the negative margin in the #astroid-menu-options in astroid-menu-options.css
#astroid-menu-options { margin-left: -180px; }
Just check the image below to see how it looks like.

Joomla Version: 4.0.4
Astroid Version: 2.5.10
Template (one) Version: 1.3.4

menuoptions

@kkaazzoo
Copy link

Hi, @BIOBILL , I do not confirm the problem

image

@vtheod
Copy link
Author

vtheod commented Nov 25, 2021

Hey @kkaazzoo!
Have you checked if there is the margin-left:-180px declaration in your css?
Also, what astroid version have you installed?

@kkaazzoo
Copy link

@BIOBILL i checked
2021-11-25_112355

image

@djayko
Copy link

djayko commented Nov 25, 2021

hello,
I can confirm this error. In the meantime I have this error also at three installations.
It also occured on my clean installation.

At the moment, I guess that I do something within the template_zero administration which is forcing this margin.
But I can't reproduce it. First everything is ok and after setting colors, logos, typography....whatever it changed from expected behaviour to margin-left: -180px

Some thougts:

  • I also see that there is the declaration from a menu.scss (SCSS!) file, but i didn't find this file anywhere

  • this margin-left definition occurs /media/astroid/assets/css/astroid-menu-options.css?v=c896a1577c58118b845c7015f8e2b430 -> my guess this file will be generated via scss, right?

  • menu.scss was found in
    \astroid\astroid-framework\assets\json\hash.json
    and
    \astroid\astroid-framework\assets\css\astroid-menu-options.css.map

  • I only found the declaration of margin-left: -180px within the https://raw.githubusercontent.com/templaza/astroid-framework/master/assets/css/astroid-menu-options.css

My guess:
Maybe there it depends somehow with scss and css??? But as I said. First everything was ok and after some time it occured (like accidently.)

Maybe this information is helpful in anyway for the developers.

best,
Frank

system-information:
joomla 4.0.4
astroid 2.5.9 and 2.5.10
astroid_template_zero 2.5.9

@vtheod
Copy link
Author

vtheod commented Nov 25, 2021

@kkaazzoo may I ask, how comes you have template version 2.5.8?
Are the templates updated?

@djayko
Copy link

djayko commented Nov 25, 2021

@kkaazzoo may I ask, how comes you have template version 2.5.8? Are the templates updated?

Mayb this is another issue. The template version (zero) on my site didn't change during joomla extension update of astroid. After download of template package here and upload to joomla, the version-number changed from 2.5.8 to 2.5.9 on my site.

@sonvnn
Copy link
Member

sonvnn commented Nov 25, 2021

Hi @BIOBILL ,

Thanks for report issue. I saw you have Dashboard Admin Bar. What is extension's name? As I know Joomla 4 default has not this toolbar. It might affect to Joomla Admin style.

143268666-b00cce04-4aff-4b4f-8d6e-76e2ee7e7c8b

Best Regards,
Sonny

@vtheod
Copy link
Author

vtheod commented Nov 25, 2021

Hi @BIOBILL ,

Thanks for report issue. I saw you have Dashboard Admin Bar. What is extension's name? As I know Joomla 4 default has not this toolbar. It might affect to Joomla Admin style.

143268666-b00cce04-4aff-4b4f-8d6e-76e2ee7e7c8b

Best Regards, Sonny

Hi @sonvnn
It's this one https://extensions.joomla.org/extension/phoca-top-menu/
It's not a conflict with the top bar. I've already checked this.

@kkaazzoo
Copy link

kkaazzoo commented Nov 25, 2021

@kkaazzoo may I ask, how comes you have template version 2.5.8? Are the templates updated?

@BIOBILL I have updated the template to the latest version, I don't see a problem

image

2021-11-25_121522

@vtheod
Copy link
Author

vtheod commented Nov 25, 2021

@kkaazzoo may I ask, how comes you have template version 2.5.8? Are the templates updated?

Mayb this is another issue. The template version (zero) on my site didn't change during joomla extension update of astroid. After download of template package here and upload to joomla, the version-number changed from 2.5.8 to 2.5.9 on my site.

I'm updating through Joomla update process and my template is still in 1.3.4 version.

@djayko
Copy link

djayko commented Nov 25, 2021

Hi @BIOBILL ,

Thanks for report issue. I saw you have Dashboard Admin Bar. What is extension's name? As I know Joomla 4 default has not this toolbar. It might affect to Joomla Admin style.

143268666-b00cce04-4aff-4b4f-8d6e-76e2ee7e7c8b

Best Regards, Sonny

I don't use that toolbar and have the same issue.
I'll try the following now:

  • clean j4 installation
  • installtion of latest stable astroid framework with templates one and zero
  • testing menu-settings
  • export my current template-settings with astroid export function
  • import my template settings with astroid import function.
  • checking menu options

best,
Frank

@sonvnn
Copy link
Member

sonvnn commented Nov 25, 2021

Hi @djayko,

May you send me your admin account via sonlv@templaza.com? I will check it on your site, because it works well on my demo.

Best Regards,
Sonny

@djayko
Copy link

djayko commented Nov 25, 2021

Hi @djayko,

May you send me your admin account via sonlv@templaza.com? I will check it on your site, because it works well on my demo.

Best Regards, Sonny

not necessary anymore from my side.

I installed everything as described above. And everything was fine.
After that i configured all from scratch. Everything still fine.
After this I installed my needed modules, components. and checked it after every installation
And I figured out that the Regular labs cache cleaner is the problem. I don't know exactly why, but after deactivation, everything was ok.

More specific:
image
It happens when this plugin is active. I try to figure out more details and will report. Maybe its an issue of the cache cleaner plugin.

@kkaazzoo Do you use regular labs cache cleaner?

@djayko
Copy link

djayko commented Nov 25, 2021

I figured out that the source code differs regarding "

"
Some of this labels are removed if Regular Labs Cache Plugin is active.

This missing Labels are causing the error.

the correct one:
</joomla-tab-element><joomla-tab-element id="attrib-astroidmenu" name="&lt;span&gt;&lt;span style='background: linear-gradient(90deg, #3F2B96 0%, #A8C0FF 100%); display: inline-block; width: 10px; height: 10px; border-radius: 10px;'&gt;&lt;/span&gt; Astroid Menu Options&lt;/span&gt;"><fieldset id="fieldset-astroidmenu" class="options-form "><legend><span><span style='background: linear-gradient(90deg, #3F2B96 0%, #A8C0FF 100%); display: inline-block; width: 10px; height: 10px; border-radius: 10px;'></span> Astroid Menu Options</span></legend><div class="form-grid"><div class="control-group"> <div class="control-label"></div> <div class="controls"> <style> #astroid-menu-options .form-control.astroid-module-search::placeholder { color: #fff; } </style>

@sonvnn is astroid doing something in generating or removing labels? I guess your answer is no. ;-)

@kkaazzoo
Copy link

@kkaazzoo Do you use regular labs cache cleaner?

@djayko No, I do not use

@djayko
Copy link

djayko commented Nov 25, 2021

@kkaazzoo Do you use regular labs cache cleaner?

@djayko No, I do not use

Any other extensions? Did you deactivate extensions or unistall it for to test, when it happens?

@kkaazzoo
Copy link

Any other extensions? Did you deactivate extensions or unistall it for to test, when it happens?

Completely clean installation

@djayko
Copy link

djayko commented Nov 25, 2021

Any other extensions? Did you deactivate extensions or unistall it for to test, when it happens?

Completely clean installation

On my fresh and clean installation, everything is ok no margin-error.
That's weird.... I've no further ideas were it comes from.

@sonvnn
Copy link
Member

sonvnn commented Nov 27, 2021

@kkaazzoo may I ask, how comes you have template version 2.5.8? Are the templates updated?

Mayb this is another issue. The template version (zero) on my site didn't change during joomla extension update of astroid. After download of template package here and upload to joomla, the version-number changed from 2.5.8 to 2.5.9 on my site.

I'm updating through Joomla update process and my template is still in 1.3.4 version.

Hi @BIOBILL,

Please help me try to disable some 3rd party extension and check it again. If it still happens please send me your admin account via sonlv@templaza.com.

I will help you check it.

Best Regards,
Sonny

@vtheod
Copy link
Author

vtheod commented Nov 29, 2021

Hey @sonvnn,

Sorry for the late response. I tried to disable all 3d party extensions, but with no success.
I created an admin account for you in case you want to check it. You'll find the credentials in your inbox.

Thanks in advance
Vassilis

@sonvnn
Copy link
Member

sonvnn commented Nov 30, 2021

Hi @BIOBILL ,

Your issue is Astroid conflict with Regular Lab - Library it same with @djayko issue.
I fixed it on 9f5569b

Please help me download developer branch and check it.

Thanks & Best Regards,
Sonny

@vtheod
Copy link
Author

vtheod commented Dec 2, 2021

Hi @sonvnn ,

Sorry for the late response. I tested the development branch locally and everything seems to work smoothly.
Thanks for your effort.

Best Regards,
Vassilis

@sonvnn sonvnn linked a pull request Dec 6, 2021 that will close this issue
@sonvnn sonvnn closed this as completed Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants