Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom.css is not loading /Astroid Framework 3.0.3 / 3.0.4 #450

Closed
ghost opened this issue Nov 14, 2023 · 5 comments · Fixed by #447
Closed

custom.css is not loading /Astroid Framework 3.0.3 / 3.0.4 #450

ghost opened this issue Nov 14, 2023 · 5 comments · Fixed by #447
Labels
bug Something isn't working SOLVED!
Milestone

Comments

@ghost
Copy link

ghost commented Nov 14, 2023

It seems that in Astroid 3.0.2 and 3.0.3 the custom.css from the root/media/templates/site/my_template/css/custom.css folder is not loaded. If I enter the css code in Astroid Backend, then it works. Can anyone confirm this?

I didn't test it in Astroid Framework 3.0 and 3.01.

Local installation in xampp 8.2.4

@ghost
Copy link
Author

ghost commented Nov 14, 2023

I just tested it in Astroid Framework 3.0. The custom.css is loaded from the root/media/templates/site/my-template/css/custom.css folder.

@Chacapamac
Copy link
Collaborator

Chacapamac commented Nov 14, 2023

@Solero-Artaxerxes
Yes, Joomla 4.1 move the css from the root/media/templates/site/my-template/css/custom.css folder and other folders to add the new Joomla ability to create “Child Templates”
a

Astroid is one of the rare Joomla framework that permit to use that feature the Joomla way.

This is an example BEFORE:
Before_Joomla_4-1-templates

This is an example AFTER: (In the “media” folder
framewor-update

This is what Happen.
Screen Shot 2022-11-04 at 2 11 36 PM

@Joomlaplates
Copy link
Collaborator

Its right, its a bug.
If you set in Astroid Plugin > Enable Inline CSS = YES
the custom.css from folder
media/templates/site/your template/css/custom.css
is not loading.
inline

@Joomlaplates Joomlaplates added the bug Something isn't working label Nov 15, 2023
@sonvnn
Copy link
Member

sonvnn commented Nov 15, 2023

Fixed in 3236585
Let's download v3-branch and retest again.
Thanks,

@sonvnn sonvnn linked a pull request Nov 15, 2023 that will close this issue
@Joomlaplates
Copy link
Collaborator

Hi Sonny,
yes its working now.
The custom.css is loading now doesnt matter if Inline CSS is "On" or "off".
And custom.css could be in template folder or media/template folder.
Both paths are working.
Thanks, youre GREAT, regards Peter

@sonvnn sonvnn added this to the Version 3.0.5 milestone Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SOLVED!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants