New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Rename --dynamic-config-value ➡️ --dynamic-config #303
Comments
This was intentionally named |
After reading the docs: https://docs.temporal.io/references/dynamic-configuration I don't see the issue with calling an individual key/value pair a "dynamic config". I think you're saying the server code calls the set of pairs a dynamic config, and a set of things is different from an individual thing? To me it seems like most CLI users won't know about that distinction, and that it's not important for them to know? Pro adding an option for dynamic config file, since I think you can't use constraints with the current option? Would use |
there was some discussion that the dynamic config can be part of the unified Server & UI config #184 If so we will not need a separate flag for dynamic config file. What do you think of this? |
I think for setting a value using What is more strongly held is that this is deployed software. You can't just go changing CLI options of this software IMO. SDK team already relies on this in multiple repositories, who knows how many others do. And even if you feel like you can change CLI options of this software, we should require a better justification for backwards incompatible alterations. |
Is it easy to keep the current option working and hide it from help output? If not, or if others don't think it's an improvement, okay to close! |
repetitive and doesn't fit pattern:
The text was updated successfully, but these errors were encountered: