Add integration test for SignalWorkflow #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
commented
Aug 19, 2020
| @@ -1239,7 +1239,7 @@ func (w *WorkflowOptions) getSignalChannel(ctx Context, signalName string) Recei | |||
| if ch, ok := w.signalChannels[signalName]; ok { | |||
| return ch | |||
| } | |||
| ch := NewBufferedChannel(ctx, defaultSignalChannelSize) | |||
| ch := NewNamedBufferedChannel(ctx, signalName, defaultSignalChannelSize) | |||
There was a problem hiding this comment.
I hope there are no side effects for this change. name is used for error message and it would be great to see something meaningful there rather then empty string.
mfateev
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding integration tests to check if
SignalWorkflowworks for primitive types and proto objects.https://community.temporal.io/t/sending-proto-messages-directly-over-signal-channels/441/3