Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm-Chart Release 1.19.0 uses temporalio/server tag=1.18.5 #344

Closed
max-matiukhin opened this issue Dec 12, 2022 · 2 comments · Fixed by #345
Closed

Helm-Chart Release 1.19.0 uses temporalio/server tag=1.18.5 #344

max-matiukhin opened this issue Dec 12, 2022 · 2 comments · Fixed by #345
Labels
bug Something isn't working

Comments

@max-matiukhin
Copy link

What are you really trying to do?

I've tried to use helm chart release 1.19.0 and expected it to use temporalio/server 1.19.0

Describe the bug

Temporal's helm-chart release 1.19.0 uses server and admin-tools version 1.18.5
I know that I can change the version myself in the values-file, however, it is unclear if it was done intentionally.
Is there any problem with temporalio/server 1.19.0?

@max-matiukhin max-matiukhin added the bug Something isn't working label Dec 12, 2022
@mindaugasrukas
Copy link
Contributor

Those are default values. And you can override any value using the --set option. For example: --set server.image.tag=1.19.0. That is a better practice than relying on the default values.

@joebowbeer
Copy link

@mindaugasrukas wrote:

Those are default values. And you can override any value using the --set option. For example: --set server.image.tag=1.19.0. That is a better practice than relying on the default values.

Going forward, I hope the server tag in the provided (default) values.yaml matches the appVersion in Chart.yaml

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 1.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants