Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Use server in expense sample #57

Closed
lorensr opened this issue Nov 7, 2021 · 1 comment
Closed

[Feature Request] Use server in expense sample #57

lorensr opened this issue Nov 7, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@lorensr
Copy link
Contributor

lorensr commented Nov 7, 2021

Looks like Val was porting the expense sample from the go one: https://github.com/temporalio/samples-go/tree/main/expense

Currently, the server code isn't used—we just start and signal the Workflow from the execute scripts directly. Server:

https://github.com/temporalio/samples-typescript/blob/main/expense/src/server/index.ts

@lorensr lorensr added the enhancement New feature or request label Nov 7, 2021
@lorensr
Copy link
Contributor Author

lorensr commented Nov 8, 2021

Nevermind, the activities use the server! I'll update the README. I was imagining the user on a website clicking a button that hit the server that sent the signal.

@lorensr lorensr closed this as completed Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant