Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of *updatepb.WaitPolicy with enum defined in the Go SDK #1411

Closed
Quinn-With-Two-Ns opened this issue Mar 6, 2024 · 0 comments · Fixed by #1489
Closed

Replace use of *updatepb.WaitPolicy with enum defined in the Go SDK #1411

Quinn-With-Two-Ns opened this issue Mar 6, 2024 · 0 comments · Fixed by #1489
Labels
enhancement New feature or request

Comments

@Quinn-With-Two-Ns
Copy link
Contributor

Using updatepb.WaitPolicy in UpdateWorkflowWithOptionsRequest is not ideal since it require declaring a whole struct and a protobuf enum just to set the wait policy. We can replace this with an "enum" defined in the Go SDK.

sdk-go/internal/internal_workflow_client.go

Line 785 in efabf46

WaitPolicy *updatepb.WaitPolicy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@Quinn-With-Two-Ns