Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search attributes are not carried forward on ContinueAsNew #1200

Closed
Tracked by #1201
robzienert opened this issue May 11, 2022 · 4 comments
Closed
Tracked by #1201

Search attributes are not carried forward on ContinueAsNew #1200

robzienert opened this issue May 11, 2022 · 4 comments
Labels
bug Something isn't working TBD This needs a broader discussion before implementing

Comments

@robzienert
Copy link

Expected Behavior

Search attributes to be carried-forward during Workflow.continueAsNew()

Actual Behavior

Continued-as-new workflows are missing the search attributes from the original run.

Steps to Reproduce the Problem

  1. Create a workflow with search attributes
  2. Call continueAsNew
  3. Verify via tctl that search attributes are missing from new run ID.

Specifications

  • Version: 1.10.0
  • Platform: 1.15.2
@Spikhalskiy Spikhalskiy added the TBD This needs a broader discussion before implementing label May 11, 2022
@Spikhalskiy
Copy link
Contributor

Spikhalskiy commented May 11, 2022

Use ContinueAsNewOptions.Builder#setSearchAttributes to pass search attributes into continueAsNew for now.

@patte
Copy link

patte commented Aug 9, 2022

Use ContinueAsNewOptions.Builder#setSearchAttributes to pass search attributes into continueAsNew for now.

Is there a similar possibility in the python SDK for retry_policy? I don't see retry_policy as a param in continue_as_new.

@Spikhalskiy
Copy link
Contributor

Spikhalskiy commented Aug 9, 2022

Is there a similar possibility in the python SDK for retry_policy? I don't see retry_policy as a param in continue_as_new.

@patte Please post as a question in #python-sdk channel of our Community Slack or as a feature request in https://github.com/temporalio/sdk-python/issues. Our Python SDK is still in beta, but this should be available there one day.

@Quinn-With-Two-Ns
Copy link
Contributor

closing in favor of #1201 since there are more attributes not passed then just SA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working TBD This needs a broader discussion before implementing
Projects
None yet
Development

No branches or pull requests

4 participants