Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpringBoot - setting target to "local" does not register ServiceStubOptionsTemplate #1815

Closed
tsurdilo opened this issue Jul 14, 2023 · 0 comments · Fixed by #1976
Closed

Comments

@tsurdilo
Copy link
Contributor

When using springboot config in local env users are told to set target prop to "local", this however just creates

WorkflowServiceStubs.newLocalServiceStubs();

see https://github.com/temporalio/sdk-java/blob/master/temporal-spring-boot-autoconfigure-alpha/src/main/java/io/temporal/spring/boot/autoconfigure/template/ServiceStubsTemplate.java#L69-L71

We should either change this to also use ServiceStubOptionsTemplate or document that when using local things like
metricsScope would not be registered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant