You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Looks like Temporal Java SDK is lacking the support of context propagators for local activities.
Currently, there is no way to make context propagation work for LocalActivities as described in Issue #489.
But even when #489 is resolved, Java SDK API lacks functionality for LocalActivities + ContextPropagators comparable to the one that is available for Activities + ContextPropagators. ActivityOption has ActivityOption#contextPropagators that allow specifying custom context propagators for the activity.
You would expect that LocalActivityOption will have LocalActivityOption#contextPropagators with the same semantic, but it's not there.
Describe the solution you'd like
Add LocalActivityOption#contextPropators and ensure they are supported the same way as ActivityOption#contextPropators
The text was updated successfully, but these errors were encountered:
After discussion with @mfateev we decided that ActivityOptions#contextPropagators has extremely limited usage.
Probably the only reasonable use case would be if we have a regular activity implemented in a different codebase or language.
Otherwise, ContextPropagators should be specified on WorkerOptions and be applied for all activities on both the caller (workflow) and activity worker side anyway, because ActivityOptions are used and applied only on a caller side. Adding a ContextPropagator just to the ActivityOptions doesn’t enable it on the Acitivity Worker side.
So, it's not a good idea to adapt it for local activities, and event the existing ActivityOptions#contextPropagators should be used carefully with full understanding that they are applied only to the client/stub side.
Is your feature request related to a problem? Please describe.
Looks like Temporal Java SDK is lacking the support of context propagators for local activities.
Currently, there is no way to make context propagation work for LocalActivities as described in Issue #489.
But even when #489 is resolved, Java SDK API lacks functionality for LocalActivities + ContextPropagators comparable to the one that is available for Activities + ContextPropagators.
ActivityOption
hasActivityOption#contextPropagators
that allow specifying custom context propagators for the activity.You would expect that
LocalActivityOption
will haveLocalActivityOption#contextPropagators
with the same semantic, but it's not there.Describe the solution you'd like
Add
LocalActivityOption#contextPropators
and ensure they are supported the same way asActivityOption#contextPropators
The text was updated successfully, but these errors were encountered: