New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve service container #88

Closed

SerafimArts opened this issue Mar 4, 2021 · 1 comment

Contributor

SerafimArts commented Mar 4, 2021 •

edited

Service container and worker factory classes:

sdk-php/src/Internal/ServiceContainer.php

Line 125 in a5a2127

public function __construct(
sdk-php/src/WorkerFactory.php

Line 286 in a5a2127

private function boot(): void

Should be rewritten using a clearer and more user-friendly approach (global PSR-11?).

We should think about solving this problem, because a certain set of services is also used in the client.

Zylius mentioned this issue

[Question] Injecting custom reader into worker factory. #110

Closed

Zylius mentioned this issue

Add support for custom reader in WorkerFactory. #115

Closed

Collaborator

wolfy-j commented Jul 11, 2023

Closing for now since the current structure is stable.

wolfy-j closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment