Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Log and drop signals that pass the wrong number of arguments #355

Open
cretz opened this issue Jul 24, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Jul 24, 2023

Describe the solution you'd like

In #349 we now drop signals whose arguments are of the wrong type. But we still fail the workflow task if the arity is off, e.g. with Python exceptions like "missing 1 required positional argument". Try to make sure there is one argument for every required parameter and no more than accepted (varargs notwithstanding). May be easiest to have a min/max param count on the _SignalDefinition and just check against that.

@cretz cretz added the enhancement New feature or request label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant