Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Failures thrown from within the update handler should be able to fail the workflow #1418

Open
ThomasBurgess2000 opened this issue May 14, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ThomasBurgess2000
Copy link

Is your feature request related to a problem? Please describe.

Currently it's a bit clumsy to fail a workflow from within an update. You have to set a flag in your updateMethod, and then in the workflow code watch for that flag and throw the failure from there (according to this post re: the java sdk at least).

Describe the solution you'd like

throw ApplicationFailure should return (or at least have the option to return) WorkflowFailedError instead of WorkflowUpdateFailedError.

Additional context

There is a similar issue active in the Java SDK repo: temporalio/sdk-java#87

@ThomasBurgess2000 ThomasBurgess2000 added the enhancement New feature or request label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant