Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add health check handler for worker service #2582

Open
tsurdilo opened this issue Mar 7, 2022 · 3 comments
Open

Add health check handler for worker service #2582

tsurdilo opened this issue Mar 7, 2022 · 3 comments
Labels
enhancement New feature or request up-for-grabs Issues to consider for external contribution

Comments

@tsurdilo
Copy link
Contributor

tsurdilo commented Mar 7, 2022

Looks as currently worker service https://github.com/temporalio/temporal/tree/master/service/worker
does not expose a gRPC handler and the health check method like matching and history services do.

Please add this if possible.

@tsurdilo tsurdilo added the enhancement New feature or request label Mar 7, 2022
@yiminc yiminc added the up-for-grabs Issues to consider for external contribution label Mar 11, 2022
@yiminc
Copy link
Member

yiminc commented Mar 11, 2022

Worker does not have a gRPC service endpoint. It would be good to have sdk to implement the health check so whoever running a worker would have it.

@paymog
Copy link

paymog commented Aug 1, 2023

While we wait for this to get implemented, does anyone have a workaround for those of us running workers in kubernetes? We recently deployed a broken docker image for our worker and didn't realize for a few days.

@tredmon
Copy link

tredmon commented Apr 1, 2024

While we wait for this to get implemented, does anyone have a workaround for those of us running workers in kubernetes?

I've just started playing with temporal in kubernetes, but a simple liveness probe could look like (assuming your image has sh and pidof installed and that your worker has a binary which is unique on your pod runtime):

livenessProbe:
  exec:
    command:
      - /bin/sh
      - -c
      - pidof your-worker-binary >/dev/null

For the readiness probe I'm considering creating a file in an emptyDir volume when the worker is ready, and creating another file when the worker receives a termination signal. Then the readiness probe could look for the existence of said files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request up-for-grabs Issues to consider for external contribution
Projects
None yet
Development

No branches or pull requests

4 participants