Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the latest version of use-wallet. #14

Closed
cswenor opened this issue Jun 28, 2023 · 11 comments
Closed

Upgrade to the latest version of use-wallet. #14

cswenor opened this issue Jun 28, 2023 · 11 comments
Labels
enhancement New feature or request

Comments

@cswenor
Copy link
Collaborator

cswenor commented Jun 28, 2023

https://twitter.com/NFDomains/status/1673836625602699269

@temptemp3
Copy link
Owner

Should be good to go

@temptemp3
Copy link
Owner

FYI, Wallet connect v2 and Exudus don't work yet

@cswenor cswenor added the enhancement New feature or request label Jun 28, 2023
@temptemp3
Copy link
Owner

Also,
MyAlgo and Algosigner are considered legacy so they were removed. Future versions of txnlab-use-wallet won't included them.

@cswenor
Copy link
Collaborator Author

cswenor commented Jun 28, 2023

wallet connect v2 don't work yet? Wsan't the announcement today that they now do?

@temptemp3
Copy link
Owner

It should work. I just have to figure out how to initialize it. Details
Screen Shot 2023-06-28 at 10 38 50
I'll have another pass soon. Hopefully it just works.

@temptemp3
Copy link
Owner

Screen Shot 2023-06-28 at 10 41 16

It shows up okay.

The error I am seeing on my device is "Invalid walletconnect link"

@temptemp3
Copy link
Owner

Probably okay for now since WalletConnect on app.testnet.nf.domains
isn't working yet. I'm working on getting a providerId from WalletConnect. We'll see how it goes.

@temptemp3
Copy link
Owner

I think the best bet here would be to go to the wallet connect v2 docs and work on a connects solution outside of txnslabs, then backtrack to what is missing. Note that in the dapp, txnslab-use-wallet is only used to connect the wallet and get the address. It also sets localstorage keys we will need in reach to use stdlib.connectAccount({addr})

@temptemp3
Copy link
Owner

May add back legacy wallets MyAlgo and possibly Algosigner

@cswenor
Copy link
Collaborator Author

cswenor commented Jun 30, 2023

Nah, you should keep them out. No reason to add them at this point since they are both abandoned projects.

@cswenor
Copy link
Collaborator Author

cswenor commented Jul 2, 2023

This is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants