Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Groups for public ingress fail 0.0.0.0/0 check #103

Closed
jeremygaither opened this issue Nov 6, 2018 · 2 comments
Closed

Security Groups for public ingress fail 0.0.0.0/0 check #103

jeremygaither opened this issue Nov 6, 2018 · 2 comments

Comments

@jeremygaither
Copy link

https://github.com/cesar-rodriguez/terrascan/blob/b4e8922a7a388a3f0351c9b0ae52d8d95cf7a95f/terrascan/checks/security_group.py#L53

Per
https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-update-security-groups.html load balancers need a source of 0.0.0.0/0 for public traffic. This test also fails for instances running VPN services, such as OpenVPN. Is there another recommended way of opening public ingress for legitimate traffic for HTTP, HTTPS, and other network protocols like OpenVPN?

@cesar-rodriguez
Copy link
Contributor

For ingress traffic from the internet what I usually do is to limit ALB traffic to CloudFront's public IP space. There might be legitimate use cases where you want to allow 0.0.0.0/0 so just use this check as a guideline for all other use cases where it's not desired.

@jeremygaither
Copy link
Author

@cesar-rodriguez Is there a way to mark that specific resources should ignore this rule?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants