Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 导入作业模版,如果文件中的主机失效(hostId:-1),导入异常 #2128

Closed
wangyu096 opened this issue Jun 13, 2023 · 0 comments
Assignees
Labels
backlog 需求初始状态,等待产品进行评估 kind/bug 程序故障Bug,漏洞

Comments

@wangyu096
Copy link
Collaborator

Version / Branch / tag

3.7.x

出了什么问题?(What Happened?)
导入作业模版,如果文件中的主机失效(hostId:-1),导入异常

2023-06-13 10:06:21.311] ERROR [job-manakFileStepDTOTaskFileStepDTOe,a0fce33cb6173f3b9cb28384ce2cabf9,b57ec1992f39a065] 129478 --- [http-nio-19803-exec-5] c.w.e.h.ServiceExceptionControllerAdvice : Handle Exception, uri: /service/app/2/template/0/saveTemplateWithVariableId

java.lang.NullPointerException: null
        at com.tencent.bk.job.manage.model.dto.task.TaskTargetDTO.lambda$fillHostDetail$0(TaskTargetDTO.java:113)
        at java.util.ArrayList.forEach(ArrayList.java:1259)
        at com.tencent.bk.job.manage.model.dto.task.TaskTargetDTO.fillHostDetail(TaskTargetDTO.java:111)
        at com.tencent.bk.job.manage.model.dto.task.TaskTargetDTO.fromVO(TaskTargetDTO.java:94)
        at com.tencent.bk.job.manage.model.dto.task.TaskFileInfoDTO.fromVO(TaskFileInfoDTO.java:100)
        at com.tencent.bk.job.manage.model.dto.task.TaskFileStepDTO.lambda$fromVO$0(TaskFileStepDTO.java:109)
        at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
        at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1384)
        at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
        at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
        at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
        at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
        at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:566)
        at com.tencent.bk.job.manage.model.dto.task.TaskFileStepDTO.fromVO(TaskFileStepDTO.java:109)
        at com.tencent.bk.job.manage.model.dto.task.TaskStepDTO.fromVO(TaskStepDTO.java:135)
        at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
        at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1384)
        at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
        at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
        at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
        at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
        at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:566)
        at com.tencent.bk.job.manage.model.dto.task.TaskTemplateInfoDTO.fromReq(TaskTemplateInfoDTO.java:172)
        at com.tencent.bk.job.manage.api.inner.impl.ServiceTaskTemplateResourceImpl.saveTemplateForMigration(ServiceTaskTemplateResourceImpl.java:171)
        at com.tencent.bk.job.manage.api.inner.impl.ServiceTaskTemplateResourceImpl$$FastClassBySpringCGLIB$$eae0c809.invoke(<generated>)
        at org.springframework.cglib.proxy.MethodProxy.invoke(MethodTaskFileStepDTOTaskFileStepDTOTaskFileStepDTOTaskFileStepDTOProxy.java:218)

如何复现?(How to reproduce?)
作业模版中包含 hostId: -1 的主机

预期结果(What you expect?)

  1. 导入按照失败的处理
@wangyu096 wangyu096 added kind/bug 程序故障Bug,漏洞 backlog 需求初始状态,等待产品进行评估 labels Jun 13, 2023
@wangyu096 wangyu096 self-assigned this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog 需求初始状态,等待产品进行评估 kind/bug 程序故障Bug,漏洞
Projects
None yet
Development

No branches or pull requests

1 participant