Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shuffle data replica? #181

Closed
zuston opened this issue Jun 16, 2022 · 5 comments
Closed

Support shuffle data replica? #181

zuston opened this issue Jun 16, 2022 · 5 comments

Comments

@zuston
Copy link
Contributor

zuston commented Jun 16, 2022

Thanks for your great work on it.

I have a question that I dont see any info about data replica support in README or other doc. But i see the config in codebase.

So the data replica is stable feature in firestorm?

@zuston
Copy link
Contributor Author

zuston commented Jun 16, 2022

And what's the difference of the config of data-replica and data-replica-writer ?

@frankliee
Copy link
Collaborator

frankliee commented Jun 17, 2022

These configs are come from quorum protocol.
rss.data.replica is default replica number of partition.
rss.data.replica.write is the minimum replica that writer should write metadata and data successfully.
rss.data.replica.read is the minimum replica that reader should read metadata successfully (data can read from only one replica).
The recommended values are (1,1,1) and (3,2,2),
This feature has been developed completely, but production environment only applies (1,1,1) to reduce rpc/memory cost.

@zuston
Copy link
Contributor Author

zuston commented Jun 17, 2022

Thanks for your explanation @frankliee.

So the data replica will be supported through client pushing instead of shuffle server.

@frankliee
Copy link
Collaborator

Thanks for your explanation @frankliee.

So the data replica will be supported through client pushing instead of shuffle server.

Yes, its client-side feature.

@zuston
Copy link
Contributor Author

zuston commented Jun 17, 2022

Thanks again. @frankliee

Close it.

@zuston zuston closed this as completed Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants