AddMember() may be incorrectly used.

[miloyip]

In upstream issue 66,

user misuse the AddMember() API:

doc.AddMember(lvl.c_str(), score, doc.GetAllocator());

lvl.c_str() is a temp string, it needs to be duplicated, otherwise when the function returns the pointer become invalid.

For this situation, the user should call

rapidjson::Value name(lvl.c_str(), doc.GetAllocator()); // copy the string
rapidjson::Value value(score);
doc.AddMember(name, value, doc.GetAllocator());

But it may be confusing for user.

All overloads of AddMember(const char* name,... ) assume the name being literal string, no need for making copies. But it may be misused like this.

Any suggestion to improve the API for DOM manipulation?