Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polaris is not flexible and extensible enough to set metadata,I hope it can be set metadata through code #31

Closed
yangjuanying opened this issue Jan 10, 2022 · 4 comments
Labels
enhancement New feature or request need discuss need discuss

Comments

@yangjuanying
Copy link
Contributor

yangjuanying commented Jan 10, 2022

Polaris is not flexible and extensible enough to set metadata here. This only through configuration “spring cloud.tencent.metadata” to set metadata. It is impossible to set metadata through code.
wecom-temp-8c5546bddccf659393ced1df2725525c

But Spring Cloud Consul and Nacos are flexible in this regard. For example, there is a customize method in the registration method of ConsulAutoRegistration
wecom-temp-25ae223f8f166e2367f90031e8b0dc6c

The user can implement the interface ConsulRegistrationCustomizer and put the customized metadata in the implementation class through code
image

It is suggested that Polaris should be modified like this in Class PolarisServiceRegistry.

@yangjuanying yangjuanying added the enhancement New feature or request label Jan 10, 2022
@chuntaojun chuntaojun added the need discuss need discuss label Jan 10, 2022
@chuntaojun
Copy link
Contributor

Okay, let's think about it here, and welcome to participate in the co-construction together to provide support for this ability~

@chuntaojun
Copy link
Contributor

@SkyeBeFreeman what do you think

@SkyeBeFreeman
Copy link
Collaborator

It is a good idea to customize the metadata with code. I will add this enhancement later.

@lepdou
Copy link
Collaborator

lepdou commented Jun 16, 2022

@yangjuanying
I have add an SPI InstanceMetadataProvider in #244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request need discuss need discuss
Projects
None yet
Development

No branches or pull requests

4 participants