Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monaco-editor依赖是否有必要? #189

Closed
kevnwei opened this issue Jul 19, 2022 · 6 comments
Closed

monaco-editor依赖是否有必要? #189

kevnwei opened this issue Jul 19, 2022 · 6 comments
Labels

Comments

@kevnwei
Copy link

kevnwei commented Jul 19, 2022

代码编辑功能使用频率本来不高(或者只需一个简单的json/js编辑器),build打包出来的文件大小,monaco-editor占比却非常高,包含各种无用语言的scripts文件。

@jia000
Copy link
Collaborator

jia000 commented Jul 19, 2022

只要不渲染,是不会去加载monaco-editor相关的的js资源的

@jia000
Copy link
Collaborator

jia000 commented Jul 19, 2022

代码编辑的频率高不高取决于业务,如果业务到后期是会有需要配置函数这种需求的,会需要在编辑器中写代码

@kevnwei
Copy link
Author

kevnwei commented Jul 19, 2022

但是貌似还是把代码打包到vendor里面了(还是我打包的姿势不对?),并且浏览器要一起下载,不管有没有渲染,页面加载比较慢影响用户体验。另外配置函数这种需求,一般都是简单的逻辑,感觉暂时不需要monaco-editor这么重量级的产品~,而且她还包含各种语言支持。

@jia000
Copy link
Collaborator

jia000 commented Jul 19, 2022

是会把monaco-editor的基础代码打进去,语言支持相关的代码是用到时才加载的

@jia000
Copy link
Collaborator

jia000 commented Jul 19, 2022

后续改成整个monaco-editor动态加载,不需要可以不加载的模式

@jia000 jia000 added the feature label Aug 15, 2022
@jia000
Copy link
Collaborator

jia000 commented Aug 30, 2022

不支持了

@jia000 jia000 closed this as completed Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants