New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC problem #101
Comments
Thanks, @aloyszhang, can you contribute a PR to this question? |
gosonzhang
pushed a commit
that referenced
this issue
Oct 31, 2019
guangxuCheng
pushed a commit
to guangxuCheng/TubeMQ
that referenced
this issue
Jul 3, 2020
…y according to Broker (Tencent#101) Co-authored-by: gosonzhang <gosonzhang@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I found some confusing code in
NettyClient#call
.when channel is null, it'll continue run the following code. It seems meaningless since
client can't send request when channel is null. I think maybe throw a
RuntimeExcetion
indicate channel is null is a better way.Another problem here, currently, when send message asynchronously, it will build a
Timeout
after write data to channel. Since build a timeout may causeRuntimeException
, it will trigger callback twice in this situaitons.The text was updated successfully, but these errors were encountered: