Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uploader.d.ts代码冲突 #3

Open
cifergit opened this issue Jun 11, 2019 · 4 comments
Open

uploader.d.ts代码冲突 #3

cifergit opened this issue Jun 11, 2019 · 4 comments

Comments

@cifergit
Copy link

版本:1.2.7之后的某个新版本有问题,1.2.7没问题
文件名:
https://github.com/tencentyun/vod-js-sdk-v6/blob/master/lib/uploader.d.ts
冲突点:
<<<<<<< HEAD

@alsotang
Copy link
Contributor

抱歉抱歉,正在看原因

@alsotang
Copy link
Contributor

我引用了 package.json,导致 ts 的编译输出目录改变了。没预料到的行为。已经发布 1.3.2 解决。麻烦再试试

@cifergit
Copy link
Author

我引用了 package.json,导致 ts 的编译输出目录改变了。没预料到的行为。已经发布 1.3.2 解决。麻烦再试试

多谢,冲突问题应该没有了,不过 1.3.2 先上传视频,成功后再上传封面情况时:
lib/src/vod_reporter.js 里VodReporter.prototype.onApply 也会被调用,并且此时 uploader.videoFile 为undefined, 所以uploader.videoFile.size 报错。

外部调用处:

this.uploader = this.tcVod.upload({
    fileId: fileId, // 先上传了视频,已知的fileId
    coverFile: opt.file, // cover File Object
});

我的理解是此时应该传coverFile 这个File Object, 无需要求videoFile了。

注:原1.2.7未报这个错,暂时已先锁定这个版本了。

@alsotang
Copy link
Contributor

  1. 这个 videoFile 的报错是实现上的遗漏,抱歉造成困扰了。
  2. 我在 reporter 的所有 function 都加上了 try,再有类似的遗漏也不会影响主流程的进行,只会打印出报错来。

版本更新到了 1.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants