Skips multiple requires of bigdecimal and date #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra requires one pr. bigdecimal or date in the YAML being loaded was taking a lot of time when used in a Rails environment. For instance it took a file containing ~10.000 big decimals 20 seconds to load, and with this change it takes 2.5 seconds
|
Could I get some feedback on this one? |
hsbt
added a commit
to ruby/ruby
that referenced
this pull request
Sep 7, 2016
This version fixed following pull requests. ruby/psych#284 ruby/psych#276 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56081 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
rhenium
pushed a commit
to rhenium/ruby
that referenced
this pull request
Sep 10, 2016
This version fixed following pull requests. ruby/psych#284 ruby/psych#276 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56081 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra requires one pr. bigdecimal or date in the
YAML being loaded was taking a lot of time when used in
a Rails environment.
For instance it took a file containing ~10.000 big decimals
20 seconds to load, and with this change it takes 2.5 seconds