Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor CollectBudget logic #61

Closed
4 tasks done
dongsam opened this issue Oct 15, 2021 · 0 comments · Fixed by #62
Closed
4 tasks done

refactor CollectBudget logic #61

dongsam opened this issue Oct 15, 2021 · 0 comments · Fixed by #62
Assignees
@dongsam
Labels
bug Something isn't working
Milestone
Budget v1.0

Comments

@dongsam
Copy link
Contributor

dongsam commented Oct 15, 2021 •
edited
Loading

Summary

  • Fix logic that can be emitted event and increase total values only without send when an exception occurs.
  • Refactor logics
  • remove unused file

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@dongsam dongsam mentioned this issue Oct 15, 2021
Merged
9 tasks
@dongsam dongsam added the bug Something isn't working label Oct 15, 2021
@dongsam dongsam self-assigned this Oct 15, 2021
@dongsam dongsam added this to the Budget v1.0 milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dongsam dongsam

Labels
bug Something isn't working
Projects
None yet
Milestone
Budget v1.0
Development

Successfully merging a pull request may close this issue.

feat: refactor collectbudget dongsam/budget
1 participant
@dongsam