Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modify some fields for naming convention in Budget object #80

Closed
4 tasks
jaybxyz opened this issue Oct 29, 2021 · 0 comments · Fixed by #85
Closed
4 tasks

feat: modify some fields for naming convention in Budget object #80

jaybxyz opened this issue Oct 29, 2021 · 0 comments · Fixed by #85
Assignees
@hallazzang
Labels
enhancement New feature or request
Milestone
Budget v1.0

Comments

@jaybxyz
Copy link
Contributor

jaybxyz commented Oct 29, 2021 •
edited by dongsam
Loading

Summary

This issue proposes to modify some fields suggested from #69 (comment) for readability and consistency.

Proposal

  • Use source_address instead of budget_source_address
  • Use destination_address instead of budget_collection_address
  • Update related docs

Tasks

  • Fix the above fields for readability and consistency

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@jaybxyz jaybxyz added the enhancement New feature or request label Oct 29, 2021
@jaybxyz jaybxyz self-assigned this Oct 29, 2021
@jaybxyz jaybxyz mentioned this issue Oct 29, 2021
Closed
9 tasks
@jaybxyz jaybxyz added this to the Budget v1.0 milestone Oct 29, 2021
@dongsam dongsam assigned hallazzang and unassigned jaybxyz Nov 1, 2021
This was referenced Nov 4, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hallazzang hallazzang

Labels
enhancement New feature or request
Projects
None yet
Milestone
Budget v1.0
2 participants
@hallazzang @jaybxyz