Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

Cosmos address (Bech32) support #65

Closed
tarcieri opened this issue Oct 15, 2018 · 3 comments
Closed

Cosmos address (Bech32) support #65

tarcieri opened this issue Oct 15, 2018 · 3 comments

Comments

@tarcieri
Copy link
Contributor

Right now all Ed25519 public keys are represented as colon-delimited hex strings:

https://github.com/tendermint/kms/blob/master/src/ed25519/public_key.rs#L28

They need to be switched over to Bech32 before launch, and ideally before GoS if we plan for KMS to be available for that.

Note: I've been working on a constant time Bech32 implementation for subtle-encoding if there's any interest in using that. Constant time isn't needed here, but subtle-encoding does so happen to already be a KMS dependency.

@jackzampolin
Copy link

Would there be required changes elsewhere? If we need this pre-GoS then we need to prioritize these changes cc @zmanian

@zmanian
Copy link
Contributor

zmanian commented Oct 15, 2018

I'll make a pull request

@zmanian
Copy link
Contributor

zmanian commented Oct 22, 2018

Closed by #71

@zmanian zmanian closed this as completed Oct 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants