This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
tendermint-rs: Initial "rpc" feature #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
tendermint-rs/rpc
branch
4 times, most recently
from
74dd08d
to
55f1404
Compare
tarcieri
commented
Apr 20, 2019
| @@ -98,7 +98,7 @@ impl State { | |||
| new_state.height, | |||
| new_state.round, | |||
| new_state.step, | |||
| self.consensus_state.block_id.unwrap(), | |||
| self.consensus_state.block_id.as_ref().unwrap(), | |||
tarcieri
force-pushed
the
tendermint-rs/rpc
branch
6 times, most recently
from
3051870
to
c55d442
Compare
tarcieri
force-pushed
the
tendermint-rs/rpc
branch
2 times, most recently
from
18bf10f
to
7fe80dc
Compare
Adds a set of JSONRPC request and response types, designed to construct JSON requests to the Tendermint RPC (HTTP) API, and parse the returned JSON responses.
Adds initial support for parsing JSON responses from the `/status` JSONRPC endpoint.
Initial support for querying blocks through the RPC API. Blocks comprise a number of different types which are generally useful (e.g. transactions), so many of them have been peppered throughout the `tendermint` crate where applicable. This commit also includes some debug output improvements, and factors algorithm types under the relevant modules.
Adds support for parsing genesis files from RPC responses. Genesis files are generic over the underlying application, and by default use `serde_json::Value` to model arbitrary JSON data.
This commit also includes a bunch of new documentation, and renames the `Timestamp` type to `Time` to better match upstream Tendermint.
tarcieri
force-pushed
the
tendermint-rs/rpc
branch
from
726b3d9
to
9fc6498
Compare
tarcieri
force-pushed
the
tendermint-rs/rpc
branch
from
9fc6498
to
ee55ffd
Compare
Parses JSONRPC responses into `tendermint::rpc::Error` with a corresponding `tendermint::rpc::error::Code` covering all presently known RPC errors.
tarcieri
changed the title
|
Removing WIP: this should be a relatively complete first pass at the RPC API. There are still several endpoints missing, I'd like to change requests to use JSON, and there's no integrated HTTP client. However, this does affect the serialization of several domain objects, namely their JSON serializations (as used in |
zmanian
approved these changes
Apr 21, 2019
|
@liamsi would appreciate some retroactive review on this, but aside from some tactical |
This was referenced Apr 21, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started developing a client-side Rust Tendermint RPC wrapper in a separate crate (
tendermint-rpc, still unreleased) and decided it might make sense to just put it thetendermintcrate for now. Based on an informal Slack poll it seems like people like that idea:This PR contains an initial client-side implementation of the Tendermint RPC API. Among other things this could potentially be used by the KMS to query validator state and e.g. update the internal block height state.
Implemented endpoints
/abci_info/block/blockchain/commit/genesis/net_info/status/validators