Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

Support Id generation from ed25519 pubkeys #291

Merged
merged 3 commits into from
Jul 16, 2019
Merged

Support Id generation from ed25519 pubkeys #291

merged 3 commits into from
Jul 16, 2019

Conversation

ebuchman
Copy link
Contributor

As far as I can tell these Id::from methods aren't even being used yet - is that right? In any case, here's the ed25519 one. Also the secp256k1 one is missing a ripemd160 if it's supposed to match Tendermint Core.

Why are these called Id and not Address?

@tarcieri tarcieri merged commit f4ddd3b into master Jul 16, 2019
@tarcieri tarcieri deleted the bucky/id branch July 16, 2019 15:03
@tarcieri
Copy link
Contributor

As far as I can tell these Id::from methods aren't even being used yet - is that right?

Correct

Also the secp256k1 one is missing a ripemd160 if it's supposed to match Tendermint Core.

Aah, I thought all RIPEMD160 usage had been eliminated. My mistake. Would you like to do a followup PR to fix that?

Why are these called Id and not Address?

I think we debated between account::Address and account::Id and chose the latter for consistency with node::Id, but changing it to Address would make sense.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants