This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
Vendor Secret Connection (fixes interchainio/tendermint-rs#27) #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 07c31d4. Reverting to restore the original Secret Connection code
...and deletes the rest of the old tendermint-rs code again, since Secret Connection is all we care about, and the rest is located at: https://github.com/interchainio/tendermint-rs
This commit wires up the Secret Connection implementation, whose code is otherwise by definition identical to the `tendermint-rs` v0.10 crate today, as it used to live in this repo and was restored by reverting it in commit 104bb82. Otherwise this is the minimum necessary changes needed to use the in-tree copy as opposed to `tendermint-rs`. It otherwise performs no changes or upgrades other than the ones needed to make the code compile and pass the latest `clippy`.
This was referenced Oct 17, 2019
Closed
This was referenced Nov 11, 2019
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in informalsystems/tendermint-rs#27, this PR reverts and wires up the original Secret Connection implementation whose code is otherwise by definition identical to the
tendermint-rsv0.10 crate today as it used to live in this repo and was restored by reverting it in commit 104bb82.Otherwise this is the minimum necessary changes needed to use the in-tree copy as opposed to
tendermint-rs. It otherwise performs no changes or upgrades other than the ones needed to make the code compile and pass the latestclippy.This is necessary, among other reasons, to perform any sort of
signatoryupgrade, as theyubihsmcrate depends on the latest ring v0.16, andtendermint-rsis stuck on ring v0.14 andring-asmprevents linking two versions. See also informalsystems/tendermint-rs#11It will also allow us to experiment with an async model with timeouts using the new Rust async features (see #352)
cc @ebuchman