Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add information about which hashing algorithm is used #57

Closed
simonvadee opened this issue Sep 25, 2017 · 1 comment
Closed

add information about which hashing algorithm is used #57

simonvadee opened this issue Sep 25, 2017 · 1 comment

Comments

@simonvadee
Copy link

I have an ABCI application storing IAVLProofs and one has to be able to validate these proofs outside of the application's context (and independently from the merkleeyes module). The application also store different kinds of merkle trees (using some other hashing algorithm), but all of them implementing the IAVL format to store merkle proofs :

type IAVLProof struct {
	LeafHash   []byte
	InnerNodes []IAVLProofInnerNode
	RootHash   []byte
}

type IAVLProofInnerNode struct {
	Height int8
	Size   int
	Left   []byte
	Right  []byte
}

The only information missing to independently validate a proof is the hsh function used to build the IAVL tree (ripemd160 in tendermint's case). My suggestion is to add a field hashFunction, either in IAVLProofInnerNode or directly in IAVLProof to make it possible for merkle proof validation systems to work with several kinds of merkle trees, including your IAVL+ implementation.

@zramsay
Copy link

zramsay commented Oct 23, 2017

Issue moved to tendermint/iavl #11 via ZenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants