Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Incompatible with Tendermint 0.16 #10

Closed
d10r opened this issue Mar 27, 2018 · 5 comments
Closed

Incompatible with Tendermint 0.16 #10

d10r opened this issue Mar 27, 2018 · 5 comments

Comments

@d10r
Copy link

d10r commented Mar 27, 2018

Due to tendermint/abci#205, this implementation has become incompatible with Tendermint v0.16 and newer.

The breakage was caused by how varints are now encoded.
Instead of a custom encoding, Tendermint now uses the protobuf default approach of ZigZag encoding.
rust-protobuf seems to support that encoding (see doc).

The update likely also requires syncing src/types.proto to the one in tendermint/abci (as far as I understand, it needs to be v1.10+). I already tried that (manually with protoc on the cmdline), but didn't yet manage to compile the included https://github.com/tendermint/abci/blob/master/types/types.proto such that the types KVPair and KI64Pairget properly included and namespaced.

Btw. the README lacks the information that protobuf support needs to be installed on the system.

@ebuchman
Copy link
Contributor

Maybe @zmanian or @adrianbrink can help here

@froggrog
Copy link

@d10r i'm fix it abci-rs

@zmanian
Copy link

zmanian commented Apr 26, 2018

Can we sync on https://github.com/tendermint/amino_rs

@froggrog
Copy link

@zmanian i think it's a good idea. how do we implement it?

@zramsay
Copy link
Contributor

zramsay commented Jul 27, 2018

closing for #12, @JacksonCoder has a fork that is using latest tendermint

@zramsay zramsay closed this as completed Jul 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants