Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

tests for protobuf stuff #36

Open
zramsay opened this issue Dec 11, 2018 · 1 comment
Open

tests for protobuf stuff #36

zramsay opened this issue Dec 11, 2018 · 1 comment

Comments

@zramsay
Copy link
Contributor

zramsay commented Dec 11, 2018

No description provided.

@zramsay zramsay mentioned this issue Dec 11, 2018
Merged
@tomtau tomtau mentioned this issue May 20, 2019
Closed
@liamsi
Copy link
Contributor

liamsi commented Jun 14, 2019

Any specifics which tests we want to see? Sth. I would like to see is a check to circleci to check if the proto files were modified and the dev forgot to regenerate (if there is a diff in the proto files, regenerate code and see if there is a diff; this works better if we use a cargo.lock; ref: #70 )

@tomtau tomtau mentioned this issue Jun 17, 2019
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@liamsi @zramsay @tac0turtle