Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

Fix Commit validation psuedocode #129

Closed
ebuchman opened this issue Aug 2, 2020 · 1 comment
Closed

Fix Commit validation psuedocode #129

ebuchman opened this issue Aug 2, 2020 · 1 comment

Comments

@ebuchman
Copy link
Contributor

ebuchman commented Aug 2, 2020

Commit validation looks like this:

for i, commitSig := range block.LastCommit.Signatures {
  if commitSig.Absent() {
    continue
  }

  vote.BlockID == block.LastBlockID

  val := state.LastValidators[i]
  vote.Verify(block.ChainID, val.PubKey) == true

  talliedVotingPower += val.VotingPower
}

Note the undefined vote type being used. Should be fixed to properly use the commitSig

@cmwaters
Copy link
Contributor

I believe this issue is no longer relevant and we can close this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants