Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Move consensus configuration into a seperate config file #2276

Closed
ValarDragon opened this issue Aug 25, 2018 · 2 comments
Closed

config: Move consensus configuration into a seperate config file #2276

ValarDragon opened this issue Aug 25, 2018 · 2 comments
Labels
C:consensus Component: Consensus S:proposal Status: Proposal

Comments

@ValarDragon
Copy link
Contributor

Most of the things in the config are local configuration parameters, which a full node operator can tune. However consensus parameters are not something the node operator should just set, they are a property of the chain. I think we should move these into a separate file from config.toml as we don't want most node operators changing these.

@melekes melekes added the S:proposal Status: Proposal label Aug 27, 2018
@ebuchman
Copy link
Contributor

Hmm not sure if these should be considered subjective params or not. Things that shouldn't be tweaked go in the genesis file. Technically these consensus config options can be changed without issue by operators however they want, though there could be some liveness issues if the timeouts diverge too much. @milosevic thoughts?

@ebuchman ebuchman added the C:consensus Component: Consensus label Aug 27, 2018
@ebuchman ebuchman added this to the v0.34 milestone Feb 28, 2019
@tac0turtle
Copy link
Contributor

closing this in favor of #2920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:consensus Component: Consensus S:proposal Status: Proposal
Projects
None yet
Development

No branches or pull requests

4 participants