remove some xxx comments and the config.mempool.recheck_empty #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebuchman
force-pushed
the
bucky/remove-some-xxx
branch
from
f513b27
to
4ed365e
Compare
ebuchman
changed the title
melekes
reviewed
Sep 28, 2018
| @@ -206,7 +206,6 @@ private_peer_ids = "{{ .P2P.PrivatePeerIDs }}" | |||
| [mempool] | |||
|
|
|||
| recheck = {{ .Mempool.Recheck }} | |||
| recheck_empty = {{ .Mempool.RecheckEmpty }} | |||
There was a problem hiding this comment.
also needs to be removed from docs/tendermint-core/configuration/md
ValarDragon
reviewed
Sep 28, 2018
| type FilePV struct { | ||
| Address types.Address `json:"address"` | ||
| PubKey crypto.PubKey `json:"pub_key"` | ||
| LastHeight int64 `json:"last_height"` | ||
| LastRound int `json:"last_round"` | ||
| LastStep int8 `json:"last_step"` | ||
| LastSignature []byte `json:"last_signature,omitempty"` // so we dont lose signatures XXX Why would we lose signatures? | ||
| LastSignBytes cmn.HexBytes `json:"last_signbytes,omitempty"` // so we dont lose signatures XXX Why would we lose signatures? |
There was a problem hiding this comment.
Perhaps change these lines to "so we maintain signatures in event of a crash"
There was a problem hiding this comment.
New comment on this struct not sufficient?
There was a problem hiding this comment.
Oh I missed it, my bad
Codecov Report
@@ Coverage Diff @@
## develop #2505 +/- ##
===========================================
- Coverage 61.35% 61.31% -0.04%
===========================================
Files 202 202
Lines 16668 16707 +39
===========================================
+ Hits 10226 10244 +18
- Misses 5580 5597 +17
- Partials 862 866 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove/update a few XXX/TODO found in the code that are stale or can be quickly addressed.
Also realized we can just remove Config.Mempool.RecheckEmpty. It defaults to
trueand was a useless option.