types: Remove pubkey from validator hash #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2512 +/- ##
===========================================
- Coverage 61.32% 61.29% -0.04%
===========================================
Files 202 202
Lines 16720 16706 -14
===========================================
- Hits 10254 10240 -14
+ Misses 5598 5596 -2
- Partials 868 870 +2
|
ebuchman
approved these changes
Oct 4, 2018
There was a problem hiding this comment.
Need to update the spec: https://github.com/tendermint/tendermint/blob/develop/docs/spec/blockchain/state.md#validator
ValarDragon
force-pushed
the
dev/rem_val_pubkey
branch
from
c97d5c7
to
f900e34
Compare
ebuchman
reviewed
Oct 5, 2018
| @@ -55,6 +55,9 @@ type Validator struct { | |||
| } | |||
| ``` | |||
|
|
|||
| When hashing the Validator struct, the pubkey is not hashed, | |||
There was a problem hiding this comment.
Lol, why not just remove it from the struct in the spec like in the code?!
There was a problem hiding this comment.
Its still in the code, its just not hashed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2477