Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto fork: consider a url like golang.tendermint.com/x/crypto #2608

Closed
ebuchman opened this issue Oct 11, 2018 · 1 comment
Closed

crypto fork: consider a url like golang.tendermint.com/x/crypto #2608

ebuchman opened this issue Oct 11, 2018 · 1 comment
Labels
C:libs Component: Library T:enhancement Type: Enhancement
Milestone

Comments

@ebuchman
Copy link
Contributor

Following up on #2558

Currently, the imports use golang.org/x/crypto and we leave comments that we actually forked it. We could make the comments clearer (#2558 (review)), but even better would be a custom URL (#2558 (comment)), though this requires the URL to actually exist else dep will throw.

We should create golang.tendermint.com/x/crypto, redirect it to the godoc, and replace the imports in the code

@ebuchman ebuchman added T:enhancement Type: Enhancement C:libs Component: Library labels Oct 11, 2018
@ebuchman ebuchman added this to the v1.0 milestone Oct 11, 2018
@liamsi
Copy link
Contributor

liamsi commented Mar 7, 2019

I think this was addressed in #3027.
We do not use the fork anymore.

@liamsi liamsi closed this as completed Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:libs Component: Library T:enhancement Type: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants