Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: Restore OriginalAddr #2668

Merged
merged 3 commits into from Oct 18, 2018
Merged

p2p: Restore OriginalAddr #2668

merged 3 commits into from Oct 18, 2018

Conversation

ebuchman
Copy link
Contributor

@ebuchman ebuchman commented Oct 18, 2018

Fixes #2618

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@codecov-io
Copy link

Codecov Report

Merging #2668 into develop will increase coverage by 0.11%.
The diff coverage is 90%.

@@             Coverage Diff             @@
##           develop    #2668      +/-   ##
===========================================
+ Coverage    61.61%   61.72%   +0.11%     
===========================================
  Files          207      207              
  Lines        16928    16944      +16     
===========================================
+ Hits         10430    10459      +29     
+ Misses        5628     5621       -7     
+ Partials       870      864       -6
Impacted Files Coverage Δ
p2p/test_util.go 66.66% <100%> (+0.25%) ⬆️
p2p/transport.go 80.36% <100%> (+0.18%) ⬆️
p2p/switch.go 51.65% <33.33%> (-0.35%) ⬇️
p2p/peer.go 60.41% <90.9%> (+2.52%) ⬆️
consensus/state.go 76.52% <0%> (+0.58%) ⬆️
consensus/reactor.go 72% <0%> (+1.41%) ⬆️

@ebuchman ebuchman mentioned this pull request Oct 18, 2018
7 tasks
@ebuchman
Copy link
Contributor Author

@melekes would appreciate review on this but I'm going to merge for now so I can start prepping the v0.26.0 release

@ebuchman ebuchman merged commit 746d137 into develop Oct 18, 2018
@ebuchman ebuchman deleted the bucky/orig-addr branch October 18, 2018 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants