You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #2670 we changes the header.Hash to use SimpleHashFromByteSlices instead of SimpleHashFromMap, since the former is a simpler and more straightforward design with less dependencies (eg. no need to build kvpairs or sort them).
We should write a test for the header.Hash. We can have both:
a test using reflect to ensure the hash is computed with the fields in the right order
a hardcoded test with actual values for the header and actual hash output that can serve as test vectors for others verifying header hashes
The text was updated successfully, but these errors were encountered:
In #2670 we changes the header.Hash to use SimpleHashFromByteSlices instead of SimpleHashFromMap, since the former is a simpler and more straightforward design with less dependencies (eg. no need to build kvpairs or sort them).
We should write a test for the header.Hash. We can have both:
reflect
to ensure the hash is computed with the fields in the right orderThe text was updated successfully, but these errors were encountered: