Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R] libs/log: add year to log format #2707

Merged
merged 2 commits into from Oct 30, 2018

Conversation

yutianwu
Copy link
Contributor

According to #2706, I encountered a problem about log format collecting logs to ELK stack for lacking year in timestamp.

Our log format before is:

NOTE[04-25|14:45:08] ABCI Replay Blocks                       module=consensus appHeight=0 storeHeight=0 stateHeight=0

I want to change it to

NOTE[2017-04-25|14:45:08] ABCI Replay Blocks                       module=consensus appHeight=0 storeHeight=0 stateHeight=0

It will help a lot to analyze logs for us.

@yutianwu yutianwu changed the title libs/log: add year to log format [R4R] libs/log: add year to log format Oct 26, 2018
@codecov-io
Copy link

Codecov Report

Merging #2707 into develop will decrease coverage by 0.2%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2707      +/-   ##
===========================================
- Coverage    61.72%   61.52%   -0.21%     
===========================================
  Files          207      207              
  Lines        16942    16942              
===========================================
- Hits         10458    10424      -34     
- Misses        5622     5652      +30     
- Partials       862      866       +4
Impacted Files Coverage Δ
libs/log/tmfmt_logger.go 88.67% <100%> (ø) ⬆️
consensus/state.go 76.17% <0%> (-2.82%) ⬇️
privval/ipc_server.go 67.92% <0%> (-1.89%) ⬇️
consensus/reactor.go 70.83% <0%> (-1.17%) ⬇️

@melekes
Copy link
Contributor

melekes commented Oct 26, 2018

Refs #1212

@yutianwu
Copy link
Contributor Author

I see, but it seems there is no conclusion. When can we sit down to reach an agreement and set out to do that. I can help.

@ebuchman ebuchman merged commit 6043795 into tendermint:develop Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants