Align Vote/Proposal fields with canonical order and fields #2730
Conversation
types/proposal.go
Outdated
| POLBlockID: polBlockID, | ||
| } | ||
| } | ||
|
|
||
| // String returns a string representation of the Proposal. | ||
| func (p *Proposal) String() string { | ||
| return fmt.Sprintf("Proposal{%v/%v %v (%v,%v) %X @ %s}", | ||
| p.Height, p.Round, p.BlockPartsHeader, p.POLRound, | ||
| return fmt.Sprintf("Proposal{%X(Proposal) %v/%v %v (%v,%v) %X @ %s}", |
There was a problem hiding this comment.
I don't think we need the %X(Proposal) since we already have Proposal{
There was a problem hiding this comment.
Thought I make it consistent with Vote but you are right. Removed.
Codecov Report
@@ Coverage Diff @@
## develop #2730 +/- ##
===========================================
- Coverage 62.2% 62.15% -0.06%
===========================================
Files 211 211
Lines 17056 17048 -8
===========================================
- Hits 10610 10596 -14
- Misses 5573 5576 +3
- Partials 873 876 +3
|
|
Updated but there seem to be some problems with circleci pulling the docker image: |
|
Still WIP? |
|
Oh we need to update spec |
|
updated the spec. Should I add an entry to the changelog, or changelog pending? |
liamsi
changed the title
We're in a twilight zone re changelog right now so don't worry about it, I'll handle it on the release front. Thanks! |
types/vote.go
Outdated
| cmn.Fingerprint(vote.ValidatorAddress), | ||
| vote.Height, | ||
| vote.Round, | ||
| return fmt.Sprintf("Vote{%v(%v) %v/%02d @ %s %X %v:%X %X}", |
There was a problem hiding this comment.
Oh I don't think we should change the order in the print statement. It's super convenient for humans to have the validator info at the front
resolves #2727