Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autofile/fsdb: comment out permissions check until someone decides to tackle #2285 #2760

Merged
merged 2 commits into from Nov 16, 2018

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Nov 5, 2018

current code results in panic and we certainly don't want that.
#2286 (comment)

Refs #2285

current code results in panic and we certainly don't want that.
#2286 (comment)
@codecov-io
Copy link

Codecov Report

Merging #2760 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2760      +/-   ##
===========================================
+ Coverage    62.21%   62.22%   +0.01%     
===========================================
  Files          212      212              
  Lines        17136    17175      +39     
===========================================
+ Hits         10661    10687      +26     
- Misses        5577     5592      +15     
+ Partials       898      896       -2
Impacted Files Coverage Δ
libs/db/fsdb.go 69.78% <ø> (+1.72%) ⬆️
libs/autofile/autofile.go 70.42% <ø> (-5.9%) ⬇️
libs/events/events.go 93.2% <0%> (-4.86%) ⬇️
libs/db/mem_db.go 82.9% <0%> (-2.39%) ⬇️
rpc/client/httpclient.go 68.78% <0%> (-0.98%) ⬇️
consensus/reactor.go 67.01% <0%> (-0.35%) ⬇️
p2p/pex/pex_reactor.go 73.05% <0%> (-0.33%) ⬇️
blockchain/pool.go 66.43% <0%> (+0.69%) ⬆️
privval/tcp_server.go 81.42% <0%> (+2.85%) ⬆️
... and 1 more

@liamsi
Copy link
Contributor

liamsi commented Nov 5, 2018

I started working on this a while ago here: 3de3969
This only fixes the calling code in the mem-pool not to panic. The other case (fsdb) doesn't come with a logger in the caller (and I wasn't sure if we need to introduce one there or use some standard way to print to standard out).

@melekes melekes changed the title comment out until someone decides to tackle #2285 autofile/fsdb: comment out permissions check until someone decides to tackle #2285 Nov 5, 2018
@ebuchman ebuchman merged commit 60018d6 into develop Nov 16, 2018
@ebuchman ebuchman deleted the 2285-handling-changed-file-permissions branch November 16, 2018 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants