#2815 do not broadcast heartbeat proposal when we are non-validator #2819
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2819 +/- ##
==========================================
- Coverage 62.51% 62.3% -0.21%
==========================================
Files 212 212
Lines 17168 17221 +53
==========================================
- Hits 10733 10730 -3
- Misses 5539 5593 +54
- Partials 896 898 +2
|
- it's enough to call getAddress() once here
|
Sorry for the noisy cosmetic commits |
|
Seems as if I'm not able to understand how to write correct tests in your framework. |
- try and use "ensure" pattern in common_test
|
OK, fixed the positive case. The negative case still looks off. |
|
@melekes fixed merge conflict vs develop after 26.2-RC0 release |
| cs.Stop() | ||
|
|
||
| // if a faulty implementation sends an event, we should wait here a little bit to make sure we don't miss it by prematurely leaving the test method | ||
| time.Sleep((proposalHeartbeatIntervalSeconds + 1) * time.Second) |
There was a problem hiding this comment.
unfortunate 3 new seconds to wait in the test. But this whole thing will go away soon anyways.
There was a problem hiding this comment.
Hmm...I could try myself on removing this proposalHeartbeat infrastructure
| @@ -1027,6 +1029,33 @@ func TestSetValidBlockOnDelayedPrevote(t *testing.T) { | |||
| assert.True(t, rs.ValidRound == round) | |||
| } | |||
|
|
|||
| // regression for #2518 | |||
Refs #2815