Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to amino 0.14.1 #2822

Merged
merged 1 commit into from Nov 13, 2018
Merged

update to amino 0.14.1 #2822

merged 1 commit into from Nov 13, 2018

Conversation

zramsay
Copy link
Contributor

@zramsay zramsay commented Nov 12, 2018

fixes int overflow that prevent tendermint from building on RPi

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@codecov-io
Copy link

codecov-io commented Nov 12, 2018

Codecov Report

Merging #2822 into develop will decrease coverage by 0.2%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2822      +/-   ##
===========================================
- Coverage    62.51%   62.31%   -0.21%     
===========================================
  Files          212      212              
  Lines        17168    17206      +38     
===========================================
- Hits         10733    10722      -11     
- Misses        5539     5584      +45     
- Partials       896      900       +4
Impacted Files Coverage Δ
privval/tcp_server.go 78.57% <0%> (-2.86%) ⬇️
p2p/trust/store.go 80.82% <0%> (-1.74%) ⬇️
consensus/reactor.go 68.37% <0%> (-0.94%) ⬇️
consensus/state.go 79.78% <0%> (-0.59%) ⬇️
privval/ipc_server.go 67.92% <0%> (+3.77%) ⬆️
libs/db/debug_db.go 20.63% <0%> (+4.63%) ⬆️

@@ -58,7 +58,7 @@

[[constraint]]
name = "github.com/tendermint/go-amino"
version = "v0.14.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it kind of weird that this now break dependencies for any downstream application who was still using v0.14.0. perhaps we should set it to allow v0.14.0 and v0.14.1, and then the downstream rasp-pi app would just select v0.14.1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't block merge, but is a general note about dependencies

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think we should switch to ^X.Y.Z or ~X.Y.Z for most of the dependencies.

@ebuchman
Copy link
Contributor

Can you redo this using dep ensure -update github.com/tendermint/go-amino so only one entry in the .lock file changes? Please and thank you :)

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💠

@melekes melekes merged commit fb10209 into develop Nov 13, 2018
@melekes melekes deleted the zach/amino branch November 13, 2018 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants