allow IPCVal to be instantiated from config #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-bowman
requested review from
ebuchman,
melekes,
xla and
zramsay
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2866 +/- ##
===========================================
+ Coverage 62.1% 62.33% +0.23%
===========================================
Files 212 212
Lines 17288 17314 +26
===========================================
+ Hits 10736 10793 +57
+ Misses 5647 5620 -27
+ Partials 905 901 -4
|
liamsi
approved these changes
Nov 17, 2018
joe-bowman
force-pushed
the
2827-privval-config
branch
2 times, most recently
from
bcf97f3
to
2af6ac5
Compare
4 tasks
melekes
reviewed
Nov 19, 2018
…v validator instantiations
joe-bowman
force-pushed
the
2827-privval-config
branch
from
d11d325
to
025df5e
Compare
|
If 0.26.4 is planned to be release in preparation for GoS, is there any chance to get this merged in too? It doesn't touch any existing code, so should be low risk but will enable some participants to run their planned production configurations for GoS. |
melekes
approved these changes
Nov 21, 2018
| @@ -2,8 +2,6 @@ | |||
|
|
|||
| ## v0.26.4 | |||
|
|
|||
| *TBD* | |||
There was a problem hiding this comment.
Suggested change
| *TBD* | |
| *TBD* |
|
|
||
| n, err := DefaultNewNode(config, log.TestingLogger()) | ||
|
|
||
| assert.NoError(t, err, "expected no err on DefaultNewNode") |
There was a problem hiding this comment.
Suggested change
| assert.NoError(t, err, "expected no err on DefaultNewNode") | |
| assert.NoError(t, err) |
|
|
||
| n, err := DefaultNewNode(config, log.TestingLogger()) | ||
|
|
||
| assert.NoError(t, err, "expected no err on DefaultNewNode") |
There was a problem hiding this comment.
Suggested change
| assert.NoError(t, err, "expected no err on DefaultNewNode") | |
| assert.NoError(t, err) |
| config.BaseConfig.PrivValidatorListenAddr = addr | ||
| n, err := DefaultNewNode(config, log.TestingLogger()) | ||
|
|
||
| assert.NoError(t, err, "expected no err on DefaultNewNode") |
There was a problem hiding this comment.
Suggested change
| assert.NoError(t, err, "expected no err on DefaultNewNode") | |
| assert.NoError(t, err) |
melekes
added a commit
that referenced
this pull request
Nov 21, 2018
* update ConsensusState#OnStop comment * consensus: set logger for WAL in tests * refactor privValidator client code and tests follow-up on #2866
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #2827
(I have since seen #2847 which is a fix for the same issue; this PR has tests and docs too ;) )