mempool: add txs from Update to cache #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2882 +/- ##
===========================================
+ Coverage 62.1% 62.16% +0.06%
===========================================
Files 212 212
Lines 17288 17293 +5
===========================================
+ Hits 10736 10750 +14
+ Misses 5647 5635 -12
- Partials 905 908 +3
|
ValarDragon
reviewed
Nov 20, 2018
mempool/mempool_test.go
Outdated
| @@ -163,6 +163,18 @@ func TestMempoolFilters(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestMempoolUpdate(t *testing.T) { | |||
There was a problem hiding this comment.
Perhaps rename to TestMempoolUpdate_cache, or something to that extent. From the name, I thought it was going to test that update removed the tx from the mempool list itself.
- rename filterTxs to removeTxs - move txsMap into removeTxs func - rename goodTxs to txsLeft
We should add txs that come in from mempool.Update to the mempool's cache, so that they never hit a potentially expensive check tx. Originally posted by @ValarDragon in #2846 #2846 (comment) Refs #2855
melekes
force-pushed
the
2855-add-txs-from-update-to-cache
branch
from
5598fe3
to
3c8d893
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2855
Updated all relevant documentation in docs