Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor blockchain reactor for better testability #2897

Closed
milosevic opened this issue Nov 21, 2018 · 3 comments
Closed

Refactor blockchain reactor for better testability #2897

milosevic opened this issue Nov 21, 2018 · 3 comments
Assignees
@milosevic @ancazamfir
Labels
C:sync Component: Fast Sync, State Sync T:enhancement Type: Enhancement T:test Type: Tests that need love
Milestone
v0.34 Stargate

Comments

@milosevic
Copy link
Contributor

Tests are "hard to read, hard to modify, hard to debug" (@melekes). One idea how tests can be improved is splitting business (algorithm) logic in a function and separate it from a real message sending. This logic should capture core algorithm, i.e., for a given state, what messages we should send and how we should react upon message reception.
@milosevic milosevic added C:sync Component: Fast Sync, State Sync T:enhancement Type: Enhancement labels Nov 21, 2018
@milosevic milosevic mentioned this issue Nov 21, 2018
Merged
@ebuchman ebuchman mentioned this issue Jan 4, 2019
Closed
@ebuchman ebuchman added this to the v1.0 milestone Jan 4, 2019
@ebuchman ebuchman added the T:test Type: Tests that need love label Jan 4, 2019
@ebuchman ebuchman modified the milestones: v1.0, v0.32.0 Feb 23, 2019
@ebuchman
Copy link
Contributor

Might need this to help do #2896 and #2699

@ebuchman ebuchman changed the title Improve tests in blockchain reactor Refactor blockchain reactor for better testability Feb 28, 2019
This was referenced Feb 28, 2019
Closed
Closed
@ebuchman ebuchman mentioned this issue Mar 16, 2019
Closed
@melekes melekes modified the milestones: v0.32.0, v0.33.0 Jun 14, 2019
@tac0turtle
Copy link
Contributor

When #3561 is merged, do we consider this closed or do we keep it open for v2 of the refactor? @milosevic @ancazamfir

@brapse brapse mentioned this issue Jul 30, 2019
Merged
5 tasks
@tac0turtle
Copy link
Contributor

Closing this as v2 was recently merged, if this needs to be open please reopen it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milosevic milosevic

@ancazamfir ancazamfir

Labels
C:sync Component: Fast Sync, State Sync T:enhancement Type: Enhancement T:test Type: Tests that need love
Projects
None yet
Milestone
v0.34 Stargate
Development

No branches or pull requests
5 participants
@melekes @milosevic @ebuchman @ancazamfir @tac0turtle