Refactor updateState #2865

[danil-lashin]

Fixes #2865

• Updated all relevant documentation in docs
• Updated all code comments where relevant
• Wrote tests
• Updated CHANGELOG_PENDING.md

[codecov-io]

Codecov Report

Merging #2929 into master will increase coverage by 0.02%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##           master    #2929      +/-   ##
==========================================
+ Coverage   62.73%   62.76%   +0.02%     
==========================================
  Files         212      212              
  Lines       17410    17409       -1     
==========================================
+ Hits        10922    10926       +4     
+ Misses       5572     5568       -4     
+ Partials      916      915       -1

Impacted Files	Coverage Δ
state/execution.go	76.31% <76.47%> (-0.11%)	⬇️
privval/tcp_server.go	78.57% <0%> (-2.86%)	⬇️
consensus/reactor.go	66.51% <0%> (+0.23%)	⬆️
rpc/client/httpclient.go	69.75% <0%> (+0.97%)	⬆️
privval/ipc_server.go	70.37% <0%> (+5.55%)	⬆️

[melekes]

🍃 🌴 🌤

Thank you

[danil-lashin]

@melekes done, thanks!

[ebuchman]

Thanks for this!

I was hoping the abciResponses could be removed all together as an argument to updateState, since we could instead just pass in ConsensusParams. But not sure if it's worth it.

Anyways, this is fine for now. The pkg could probably continue to use some code structure improvements in the future.